Repository navigation
🤖 [codex] Honor FIREHOSE_DISABLED when installing the execution extension - #7
Open
DenisCarriere wants to merge 1 commit into
Open
DenisCarriere wants to merge 1 commit into
DenisCarriere wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIREHOSE_DISABLED=truecurrently starts an RPC node and then terminates it when the Firehose execution extension panics withfirehose tracer not initialized — call init_tracer first. This was reproduced againstdev-049d306-fh3.1-3while preparing the BSC archive packages for pinax-network/k8s-archive#100 and pinax-network/k8s-archive#103.Install the extension only when tracer initialization is enabled. The existing
NodeBuilder::install_exex_ifAPI preserves the enabled path and avoids starting an extension without its required global state. This targetsrelease/develop-fh, the source of the affected release; the repository's defaultmainis the separate non-Firehose upstream line.Validation:
bnb-rethdependency.git diff --checkpassed.🤖 Created by Codex GPT-6 (effort: not exposed by runtime)