Skip to content

🤖 [codex] Honor FIREHOSE_DISABLED when installing the execution extension - #7

Open
DenisCarriere wants to merge 1 commit into
release/develop-fhfrom
codex/honor-firehose-disabled
Open

DenisCarriere wants to merge 1 commit into
release/develop-fhfrom
codex/honor-firehose-disabled

Conversation

@DenisCarriere

Copy link
Copy Markdown

FIREHOSE_DISABLED=true currently starts an RPC node and then terminates it when the Firehose execution extension panics with firehose tracer not initialized — call init_tracer first. This was reproduced against dev-049d306-fh3.1-3 while preparing the BSC archive packages for pinax-network/k8s-archive#100 and pinax-network/k8s-archive#103.

Install the extension only when tracer initialization is enabled. The existing NodeBuilder::install_exex_if API preserves the enabled path and avoids starting an extension without its required global state. This targets release/develop-fh, the source of the affected release; the repository's default main is the separate non-Firehose upstream line.

Validation:

  • Reproduced the crash with the published image, an empty temporary database, non-root execution and an isolated Docker network.
  • Confirmed the conditional builder API in the pinned bnb-reth dependency.
  • git diff --check passed.
  • Cargo checks and image build run on this PR. The archive PR also boots both network manifests and checks chain ID/genesis, HTTP, WebSocket, metrics and IPC with tracing disabled before Chapel activation.

🤖 Created by Codex GPT-6 (effort: not exposed by runtime)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant